[WIP] fix: remove extra return -> in laravel keys
#4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto issue-4563
for more information, see https://pre-commit.ci
nijel
reviewed
Oct 25, 2022
| 'apples' => 'There is one apple|There are many apples', | ||
| ]; | ||
| """ | ||
| phpsource = open("./laravel/plurals.php").read() |
There was a problem hiding this comment.
You cannot make assumptions about current working directory. Either derive the filename from __file__ and make sure the test files are included in the package, or inline it as it was done before.
|
@Simoneu01 Any progress on this? |
|
I tried this patch on weblate 3.14 and it resolves the issue with Laravel language import. What is holding us back to merge it? |
Sorry, I've been busy IRL.
This PR has some issues when the language file has comments on it, and also breaks the indentation. I'll look into it in the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4563
Close WeblateOrg/weblate#5633
This is still a WIP please do not review now
Next steps: