Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault interface #237

Merged
merged 22 commits into from
Nov 23, 2024
Merged

Vault interface #237

merged 22 commits into from
Nov 23, 2024

Conversation

miohtama
Copy link
Contributor

@miohtama miohtama commented Nov 16, 2024 •
edited
Loading

  • Abstract away vault interactions to its own encapsulating interface
    • Initial, partial, implementation
  • Add: Vault abstraction framework to easily work with different onchain vaults
  • Add: eth_defi.velvet
  • Add: QuoterV2 support for Uniswap v3 - needed to get Base prices

@miohtama
Fleshing out the vault interface
21c574e
@miohtama
Adding Velvet test cases
49e2680
@miohtama
Velvet portfolio reading works
3177583
@miohtama
Swap partially simulation works
5d5482e
@miohtama
Multiple Enso swap tests pass
f0496ad
@miohtama
Correctly marking test to be skipped
d784ff3
@miohtama
Correctly mark test skipped
e2502aa
@miohtama
Add multicall token balance reader
d65fa95
@miohtama
Add negative test
a3dfe68
@miohtama
Docstring
b56f94f
@miohtama
Mark step skipped as it is giving headache
fd509b4
@miohtama
Add swap test
9b4b338
@miohtama
Uniswap QuoterV2 missing
18aef7f
@miohtama
Cram in new Uni v2 perihelia contracts
55c6ea7
@miohtama
DogInMe price fetch works
9f0580a
@miohtama
Periheplia NonfungibleTokenPositionDescriptor has new constructor ABI…
ee3ed87 
… in v1.3.0
@miohtama
Add logging to quoter
510fcfd
@miohtama
Fix fee array to be in wrong order when using estimate_sell_received_…
1c085ab 
…amount
@miohtama
Add estimate_sell_received_amount() test
2cd2369
@miohtama
Enso tests regularly fail, I have no idea why
8e2b9ca
@miohtama miohtama changed the title Started to work on a generic vaut spec Vault interface Nov 23, 2024
@miohtama miohtama merged commit b25c58b into master Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miohtama