Algo: Introduce support for pods metric query as workload external query & other tweaks #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Zhu <zzqshu@126.com>
Signed-off-by: Zach Zhu <zzqshu@126.com>
Signed-off-by: Zach Zhu <zzqshu@126.com>
zqzten
added
kind/feature
dayko2019
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind algorithm
What this PR does / why we need it:
This PR introduces support for pods metric query as workload external query.
Previously, the workload external query is only used as a special case of external metric query for ready replicas history query in the predictive portrait algorithm. After some thoughts, I found its semantics more close to pods metric query because it gathers metric of workload's pods just like the workload resource query for the resource metric query under history query cases. This change can also bring unified behavior for pods and external metric query.
This PR also contains some other tweaks for the algorithm scripts, please see changes for details.