Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote trailing slash from bootstrap #2875

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Firstyear
Copy link
Contributor

With autoconf 2.72, the trailing / in bootstrap causes cryptic build failures to occur on MacOS. Removing these / allows autoconf to proceed.

And example of the error is:

# ./bootstrap
Generating file lists: src_vars.mk
aminclude_static.am:63: warning: GITIGNOREFILES was already defined in condition TRUE, which includes condition AUTOCONF_CODE_COVERAGE_2019_01_06 and CODE_COVERAGE_ENABLED ...
Makefile.am:56:   'aminclude_static.am' included from here
Makefile.am:52: ... 'GITIGNOREFILES' previously defined here
Makefile.am: error: object 'src/tss2-esys/libtss2_esys_la-esys_crypto_mbed.lo' created by 'src/tss2-esys/esys_crypto_mbed.c' and 'src/tss2-esys//esys_crypto_mbed.c'
Makefile.am: error: object 'src/tss2-esys/libtss2_esys_la-esys_crypto_ossl.lo' created by 'src/tss2-esys/esys_crypto_ossl.c' and 'src/tss2-esys//esys_crypto_ossl.c'
autoreconf: error: automake failed with exit status: 1

Note the double // in src/tss2-esys//esys_crypto_mbed.c

With autoconf 2.72, the trailing / in bootstrap causes cryptic build failures
to occur on MacOS. Removing these / allows autoconf to proceed.

Signed-off-by: William Brown <william@blackhats.net.au>
@Firstyear
Copy link
Contributor Author

Relates parallaxsecond/rust-tss-esapi#523

@AndreasFuchsTPM
Copy link
Member

If that's the output, then it sounds like find does not work correctly on MacOS.

Is the output really different for find ./ vs find . ?

Nevertheless, I'll merge this once tests pass, but you might want to file a bug with MacOS's find as well.

@Firstyear
Copy link
Contributor Author

If that's the output, then it sounds like find does not work correctly on MacOS.

Could be a BSD find thing?

Is the output really different for find ./ vs find . ?

[william@maxixe 11:55] /tmp/testfoo # find .
.
[william@maxixe 11:55] /tmp/testfoo # find ./
./

Seems so.

@AndreasFuchsTPM AndreasFuchsTPM merged commit 4aeef55 into tpm2-software:master Aug 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants