tcti-libtpms: fix big endian response size. #2701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size_t was used for the sizes determined by the TPMLIB_Process call. TPMLIB_Process uses uint32_t values. This did work on little endian architectures. On big endian architectures wrong sizes were computed by the tcti receive function. Now uint32_t parameters are used for the TPMLIB_Process call. Signed-off-by: Juergen Repp <juergen_repp@web.de>
Codecov Report
@@ Coverage Diff @@
## master #2701 +/- ##
==========================================
+ Coverage 82.57% 82.59% +0.02%
==========================================
Files 368 368
Lines 42986 42998 +12
==========================================
+ Hits 35496 35516 +20
+ Misses 7490 7482 -8
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
was already fixed by #2675. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_t was used for the sizes determined by the TPMLIB_Process call. TPMLIB_Process uses uint32_t values. This did work on little endian architectures. On big endian architectures wrong sizes were computed by the tcti receive function. Now uint32_t parameters are used for the TPMLIB_Process call.
Signed-off-by: Juergen Repp juergen_repp@web.de