Do not consider failures to write files in /sys hard errors #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasFuchsTPM
approved these changes
Oct 18, 2023
AndreasFuchsTPM
requested changes
Oct 18, 2023
systemd-tmpfiles can run in containers, chroots, ... where writing to /sys will fail, so let's suffix these lines with "-" to avoid considering these cases hard errors. Signed-off-by: Daan De Meyer <daan.j.demeyer@gmail.com>
DaanDeMeyer
force-pushed
the
DaanDeMeyer-patch-1
branch
from
73ce6ef
to
c61be2b
Compare
|
Added signed off tag |
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
+ Coverage 82.54% 82.58% +0.03%
==========================================
Files 368 368
Lines 42941 42995 +54
==========================================
+ Hits 35447 35508 +61
+ Misses 7494 7487 -7 see 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AndreasFuchsTPM
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-tmpfiles can run in containers, chroots, ... where writing to /sys will fail, so let's suffix these lines with "-" to avoid considering these cases hard errors.