Tpm2-tss build with VS2019 + Windows ARM64 #2182

achal1012 · 2021-10-22T23:28:44Z

No description provided.

AndreasFuchsTPM · 2022-06-14T10:46:56Z

First of all: Our .gitignore file is autogenerated. We don't want to add it just for Windows env. IMHO windows should be able to know which files it generates by itself quite nicely without need for a .gitignore, or am I wrong ?

Then: Are you still working on this (since this was a "draft") or have you given up ?

achal1012 · 2022-06-14T14:23:31Z

First of all: Our .gitignore file is autogenerated. We don't want to add it just for Windows env. IMHO windows should be able to know which files it generates by itself quite nicely without need for a .gitignore, or am I wrong ?

Then: Are you still working on this (since this was a "draft") or have you given up ?

Hi @AndreasFuchsTPM you are right; gitignore was required for our dev setup.
I have no intention to merge this in unless the authours of this repo want me to; I just created this draft PR so my teammates can look at the diff and build this for ARM64 platform. :)

williamcroberts · 2022-06-14T14:46:33Z

I guess we could take the changes to the project files. For the gitignore you can add it to .git/info/exclude. Everyone who works on it can just drop it in there. This is per: https://www.atlassian.com/git/tutorials/saving-changes/gitignore#personal-git-ignore-rules

achal1012 · 2022-06-14T14:58:15Z

I guess we could take the changes to the project files. For the gitignore you can add it to .git/info/exclude. Everyone who works on it can just drop it in there. This is per: https://www.atlassian.com/git/tutorials/saving-changes/gitignore#personal-git-ignore-rules

Sure let me fix the changes and publish the pull request.

williamcroberts · 2022-10-26T14:50:54Z

@achal1012 I took the liberty of fixing the merge conflicts since we took so long to review this again. Could you sign off your commits though to make the DCO bot happy?

AndreasFuchsTPM · 2022-11-15T14:25:42Z

IMHO we should squash the two commits into a single one.

@achal1012 Could you provide some reference to the target platform you are using so we could setup our own testing env for this ?

achal1012 · 2022-11-15T15:09:14Z

Hi @williamcroberts: I am unable to approve this PR as github is not letting me. And I apologize for no updates on this PR, I changed employers and lost my setup and test bench.

@AndreasFuchsTPM I tested this on Ampere platform with internal windows ARM564 build, and unfortunately I don't have access to that now.

williamcroberts · 2022-11-15T16:06:11Z

Hi @williamcroberts: I am unable to approve this PR as github is not letting me.

You don't need to approve anything, You can still sign off your commits. In the Tests section for your PR you'll see a DCO thing that shows as failed, follow it's steps:

https://github.com/tpm2-software/tpm2-tss/pull/2182/checks?check_run_id=9119972325

And I apologize for no updates on this PR, I changed employers and lost my setup and test bench.

We'll as long as it didn't break the normal x86-64 builds so I am fine with pulling it as is as experimental ARM64 support.

Signed-off-by: Achal Velani <achal.velani@gmail.com>

achal1012 · 2022-11-15T16:27:45Z

You don't need to approve anything, You can still sign off your commits. In the Tests section for your PR you'll see a DCO thing that shows as failed, follow it's steps:

https://github.com/tpm2-software/tpm2-tss/pull/2182/checks?check_run_id=9119972325

I followed the steps and pushed the change. Can you check if its okay now?

williamcroberts · 2022-11-16T20:51:25Z

You don't need to approve anything, You can still sign off your commits. In the Tests section for your PR you'll see a DCO thing that shows as failed, follow it's steps:

https://github.com/tpm2-software/tpm2-tss/pull/2182/checks?check_run_id=9119972325

I followed the steps and pushed the change. Can you check if its okay now?

DCO bot happy, lets let CI spin and I can pull this in for 4.0 release.

AndreasFuchsTPM

AppVeyor complains that
esys_crypto_ossl.c(11,10): fatal error : 'openssl/rand.h' file not found [C:\projects\tpm2-tss\src\tss2-esys\tss2-esys.vcxproj]

I see that include-paths were changed for OpenSSL.
I don't know though, how to nicely handle this.

AndreasFuchsTPM · 2022-11-17T11:10:29Z

src/tss2-esys/tss2-esys.vcxproj

    </ClCompile>
    <Link>
      <TargetMachine>MachineX86</TargetMachine>
      <GenerateDebugInformation>true</GenerateDebugInformation>
      <SubSystem>Windows</SubSystem>
-      <AdditionalDependencies>$(OutDir)\tss2-mu.lib;$(OutDir)\tss2-sys.lib;$(OutDir)\tss2-tctildr.lib;C:\OpenSSL-v11-Win32\lib\libcrypto.lib;C:\OpenSSL-v11-Win32\lib\libcrypto.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <AdditionalDependencies>$(OutDir)\tss2-mu.lib;$(OutDir)\tss2-sys.lib;$(OutDir)\tss2-tctildr.lib;C:\OpenSSL.1.1.1506.73\$(Platform)\$(Configuration)\lib\libcrypto.lib;%(AdditionalDependencies)</AdditionalDependencies>


This change apparently breaks our Appveyor-CI

AndreasFuchsTPM · 2022-11-17T11:10:38Z

src/tss2-esys/tss2-esys.vcxproj

    </ClCompile>
    <Link>
      <TargetMachine>MachineX86</TargetMachine>
      <GenerateDebugInformation>true</GenerateDebugInformation>
      <SubSystem>Windows</SubSystem>
      <EnableCOMDATFolding>true</EnableCOMDATFolding>
      <OptimizeReferences>true</OptimizeReferences>
-      <AdditionalDependencies>$(OutDir)\tss2-mu.lib;$(OutDir)\tss2-sys.lib;$(OutDir)\tss2-tctildr.lib;C:\OpenSSL-v11-Win32\lib\libcrypto.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <AdditionalDependencies>$(OutDir)\tss2-mu.lib;$(OutDir)\tss2-sys.lib;$(OutDir)\tss2-tctildr.lib;C:\OpenSSL.1.1.1506.73\$(Platform)\$(Configuration)\lib\libcrypto.lib;%(AdditionalDependencies)</AdditionalDependencies>


AndreasFuchsTPM · 2022-11-17T11:10:54Z

src/tss2-esys/tss2-esys.vcxproj

      <ModuleDefinitionFile>$(SolutionDir)\lib\tss2-esys.def</ModuleDefinitionFile>
    </Link>
  </ItemDefinitionGroup>
  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
    <ClCompile>
-      <AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)\src;$(SolutionDir)\include\tss2;$(SolutionDir)\src\tss2-mu;$(SolutionDir)\src\tss2-sys;$(SolutionDir)\src\tss2-esys;C:\OpenSSL-v11-Win64\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)\src;$(SolutionDir)\include\tss2;$(SolutionDir)\src\tss2-mu;$(SolutionDir)\src\tss2-sys;$(SolutionDir)\src\tss2-esys;C:\OpenSSL.1.1.1506.73\$(Platform)\$(Configuration)\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>


AndreasFuchsTPM · 2022-11-17T11:11:07Z

src/tss2-esys/tss2-esys.vcxproj

      <PreprocessorDefinitions>NDEBUG;_WINDOWS;_USRDLL;TSS2ESYS_EXPORTS;MAXLOGLEVEL=6;strtok_r=strtok_s;OSSL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
    </ClCompile>
    <Link>
-      <AdditionalDependencies>$(OutDir)\tss2-mu.lib;$(OutDir)\tss2-sys.lib;$(OutDir)\tss2-tctildr.lib;C:\OpenSSL-v11-Win64\lib\libcrypto.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <AdditionalDependencies>$(OutDir)\tss2-mu.lib;$(OutDir)\tss2-sys.lib;$(OutDir)\tss2-tctildr.lib;C:\OpenSSL.1.1.1506.73\$(Platform)\$(Configuration)\lib\libcrypto.lib;%(AdditionalDependencies)</AdditionalDependencies>


williamcroberts · 2022-11-17T17:55:24Z

AppVeyor complains that esys_crypto_ossl.c(11,10): fatal error : 'openssl/rand.h' file not found [C:\projects\tpm2-tss\src\tss2-esys\tss2-esys.vcxproj]

I see that include-paths were changed for OpenSSL. I don't know though, how to nicely handle this.

If it breaks appveyor we don't pull, @achal1012 if you can add your arm64 support and AppVeyor is happy thats good enough for me, but otherwise we won't be able to take this PR. I thought AppVeyor was happy at one point....

achal1012 · 2022-11-24T00:10:34Z

AppVeyor complains that esys_crypto_ossl.c(11,10): fatal error : 'openssl/rand.h' file not found [C:\projects\tpm2-tss\src\tss2-esys\tss2-esys.vcxproj]
I see that include-paths were changed for OpenSSL. I don't know though, how to nicely handle this.

If it breaks appveyor we don't pull, @achal1012 if you can add your arm64 support and AppVeyor is happy thats good enough for me, but otherwise we won't be able to take this PR. I thought AppVeyor was happy at one point....

Yes, I think here we have to use a build of OpenSSL that has the ARM64 libs as well.
C:\OpenSSL.1.1.1506.73
This was a hardcoded version I was using.

achal1012 · 2022-11-24T00:11:01Z

Can we keep this PR in draft till I can find some time to work on this? Or do we need to abandon it?

williamcroberts · 2022-11-25T19:25:12Z

Can we keep this PR in draft till I can find some time to work on this? Or do we need to abandon it?

We can just leave it open

achal1012 marked this pull request as ready for review June 16, 2022 21:09

williamcroberts previously approved these changes Oct 26, 2022

View reviewed changes

williamcroberts dismissed their stale review via 3fc020a October 26, 2022 14:50

williamcroberts force-pushed the dev/achal/buildVS19andARM64 branch from 91cd03e to 3fc020a Compare October 26, 2022 14:50

achal1012 requested a review from williamcroberts November 15, 2022 15:04

acvelani and others added 2 commits November 15, 2022 08:26

vcxproj changs

e00af0a

Signed-off-by: Achal Velani <achal.velani@gmail.com>

remove added .gitignore

05fe8c6

Signed-off-by: Achal Velani <achal.velani@gmail.com>

achal1012 force-pushed the dev/achal/buildVS19andARM64 branch from 3fc020a to 05fe8c6 Compare November 15, 2022 16:26

williamcroberts added this to the Version 4.0 milestone Nov 16, 2022

AndreasFuchsTPM requested changes Nov 17, 2022

View reviewed changes

williamcroberts removed this from the Version 4.0 milestone Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tpm2-tss build with VS2019 + Windows ARM64 #2182

Tpm2-tss build with VS2019 + Windows ARM64 #2182

achal1012 commented Oct 22, 2021

AndreasFuchsTPM commented Jun 14, 2022

achal1012 commented Jun 14, 2022

williamcroberts commented Jun 14, 2022

achal1012 commented Jun 14, 2022

williamcroberts commented Oct 26, 2022

AndreasFuchsTPM commented Nov 15, 2022

achal1012 commented Nov 15, 2022

williamcroberts commented Nov 15, 2022

achal1012 commented Nov 15, 2022

williamcroberts commented Nov 16, 2022

AndreasFuchsTPM left a comment

AndreasFuchsTPM Nov 17, 2022

AndreasFuchsTPM Nov 17, 2022

AndreasFuchsTPM Nov 17, 2022

AndreasFuchsTPM Nov 17, 2022

williamcroberts commented Nov 17, 2022

achal1012 commented Nov 24, 2022

achal1012 commented Nov 24, 2022

williamcroberts commented Nov 25, 2022

Tpm2-tss build with VS2019 + Windows ARM64 #2182

Are you sure you want to change the base?

Tpm2-tss build with VS2019 + Windows ARM64 #2182

Conversation

achal1012 commented Oct 22, 2021

AndreasFuchsTPM commented Jun 14, 2022

achal1012 commented Jun 14, 2022

williamcroberts commented Jun 14, 2022

achal1012 commented Jun 14, 2022

williamcroberts commented Oct 26, 2022

AndreasFuchsTPM commented Nov 15, 2022

achal1012 commented Nov 15, 2022

williamcroberts commented Nov 15, 2022

achal1012 commented Nov 15, 2022

williamcroberts commented Nov 16, 2022

AndreasFuchsTPM left a comment

Choose a reason for hiding this comment

AndreasFuchsTPM Nov 17, 2022

Choose a reason for hiding this comment

AndreasFuchsTPM Nov 17, 2022

Choose a reason for hiding this comment

AndreasFuchsTPM Nov 17, 2022

Choose a reason for hiding this comment

AndreasFuchsTPM Nov 17, 2022

Choose a reason for hiding this comment

williamcroberts commented Nov 17, 2022

achal1012 commented Nov 24, 2022

achal1012 commented Nov 24, 2022

williamcroberts commented Nov 25, 2022