Skip to content

Commit

Permalink
tss2-tcti: tcti-libtpms: fix test failure on big-endian platform
Browse files Browse the repository at this point in the history
Due to tcti_libtpms->response_len and tcti_libtpms->response_buffer_len
are size_t. We cannot convert the (size_t *) to (uint32_t *) on big-endian
platforms. Thus we create temp uint32_t variables. Make the call and
then assign it back to size_t variables.

This commit partially fix the test failure on big-endian platforms.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
  • Loading branch information
grandpaul authored and JuergenReppSIT committed Nov 5, 2023
1 parent 761d15a commit ede63dd
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/tss2-tcti/tcti-libtpms.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,8 @@ tcti_libtpms_transmit(
tpm_header_t header;
TSS2_RC rc;
TPM_RESULT ret;
uint32_t resp_size;
uint32_t respbufsize;

rc = tcti_common_transmit_checks(tcti_common, cmd_buf, TCTI_LIBTPMS_MAGIC);
if (rc != TSS2_RC_SUCCESS) {
Expand All @@ -400,11 +402,16 @@ tcti_libtpms_transmit(
}

LOGBLOB_DEBUG(cmd_buf, size, "Sending command with TPM_CC 0x%" PRIx32, header.size);
resp_size = (uint32_t) tcti_libtpms->response_len;
respbufsize = (uint32_t) tcti_libtpms->response_buffer_len;
LIBTPMS_API_CALL(fail, tcti_libtpms, TPMLIB_Process, &tcti_libtpms->response_buffer,
(uint32_t *) &tcti_libtpms->response_len,
(uint32_t *) &tcti_libtpms->response_buffer_len,
(uint32_t *) &resp_size,
(uint32_t *) &respbufsize,
(uint8_t *) cmd_buf,
size);
tcti_libtpms->response_len = resp_size;
tcti_libtpms->response_buffer_len = respbufsize;

rc = tcti_libtpms_store_state(tcti_libtpms);
if (rc != TSS2_RC_SUCCESS) {
LOG_ERROR("Failed to store state file");
Expand Down

0 comments on commit ede63dd

Please sign in to comment.