Cli redesign #88
Merged
Cli redesign #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oskar Kohout <oskar@evilbit.at>
Signed-off-by: Oskar Kohout <oskar@evilbit.at>
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 4 4
Lines 802 802
=======================================
Hits 655 655
Misses 147 147
Continue to review full report at Codecov.
|
diabonas
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
LGTM, cheers! According to the SemVer specification
Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
So I don't see any issues in merging this now and including it into the next minor release 0.4.0 :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #87
Introduces breaking changes in CLI API, so maybe earmark for v1.0