Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala.js support #138

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

scala.js support #138

wants to merge 6 commits into from

Conversation

minettiandrea
Copy link

Hi Toshiyuki,

I've used your library in many projects, recently I've been using scala.js quite a lot and I was missing a good csv library so I've tried to do a porting of your library, and actually it was quite simple so here the pull request.

It didn't changed the API for the JVM, i've just added an object CSV to access read and write directly (without writing or reading a file).

The method in CSV are:

def read(input: String)(implicit format: CSVFormat): List[List[String]]
def writeAll(input: Seq[Seq[String]])(implicit format: CSVFormat): String
def writeRow(input: Seq[String])(implicit format: CSVFormat): String 

It would be great if you could merge my pull request and release it on the maven repository, I guess also for the library to be listed between the libraries that are supporting scala.js would be a good visibility.

Regards and thank you for your great work

Andrea

@xuwei-k xuwei-k removed their request for review March 31, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant