Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enums not quoted #1776

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Nov 18, 2024

Description

Fixes #1774
Depends on tortoise/pypika-tortoise#10

Motivation and Context

Create this PR to verify the latest commit of pypika-tortoise

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11908885790

Details

  • 195 of 213 (91.55%) changed or added relevant lines in 27 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 89.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/mysql/executor.py 4 5 80.0%
tortoise/contrib/postgres/functions.py 9 10 90.0%
tortoise/contrib/postgres/json_functions.py 2 3 66.67%
tortoise/queryset.py 15 16 93.75%
tortoise/validators.py 28 29 96.55%
tortoise/contrib/postgres/regex.py 2 4 50.0%
tortoise/contrib/mysql/json_functions.py 11 16 68.75%
tortoise/filters.py 13 19 68.42%
Files with Coverage Reduction New Missed Lines %
tortoise/contrib/mysql/search.py 1 68.97%
Totals Coverage Status
Change from base Build 11908515480: 0.2%
Covered Lines: 6231
Relevant Lines: 6853

💛 - Coveralls

tests/test_filters.py Show resolved Hide resolved
tests/test_q.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
abondar
abondar previously approved these changes Nov 19, 2024
@henadzit
Copy link
Contributor

@waketzheng no need to change about this PR but it would be great to have two separate PRs in the future when you want to refactor the code. In this example it would be:

  • PR for fixing enums not quoted
  • Adding type hints

Having everything as a single PR makes it really hard to review actual logic changes. Thanks!

@waketzheng
Copy link
Contributor Author

@waketzheng no need to change about this PR but it would be great to have two separate PRs in the future when you want to refactor the code. In this example it would be:

  • PR for fixing enums not quoted
  • Adding type hints

Having everything as a single PR makes it really hard to review actual logic changes. Thanks!

OK~

@waketzheng
Copy link
Contributor Author

@abondar Cloud you merge it

@abondar abondar merged commit 49b36ad into tortoise:develop Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums not quoted (bug of pypika-torotise)
4 participants