New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous column name when grouping with joins #1766

Merged

abondar merged 1 commit into tortoise:develop from henadzit:fix/ambigious-name-in-order-by

Nov 14, 2024

Contributor

henadzit commented Nov 10, 2024 •

edited

Loading

Description

Adds aliases to GROUP BY statements which helps to avoid ambiguous name errors.

Motivation and Context

This should fix #1386 and fix #1175.

How Has This Been Tested?

Added tests

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          Fix ambiguous column name when grouping with joining

b0b815e

coveralls commented Nov 10, 2024

Pull Request Test Coverage Report for Build 11766871659

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.162%

Totals
Change from base Build 11764062074:	0.0%
Covered Lines:	6084
Relevant Lines:	6709

💛 - Coveralls

abondar approved these changes

View reviewed changes

abondar merged commit 905daaa into tortoise:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet