Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for FastAPI lifespan support (#1371) #1540

Closed

Conversation

waketzheng
Copy link
Contributor

  • Add a new class RegisterTortoise which can be used in lifespan context
  • Enhancement register_tortoise to auto run in lifespan context, but echo deprecated warning

Description

Support register in fastapi's lifespan and leave register_tortoise there to compare old version

Motivation and Context

For some running projects, people may want to only upgrade dependencies without changing any code.

While for new project, it is more flexibility to use async with format to register db.

How Has This Been Tested?

make test
cd examples/fastapi && PYTHONPATH=. pytest _tests.py

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant