Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.2.0-alpha release #105

Merged
merged 94 commits into from
Jan 1, 2019
Merged

v0.2.0-alpha release #105

merged 94 commits into from
Jan 1, 2019

Conversation

toonarmycaptain
Copy link
Owner

No description provided.

@toonarmycaptain
Merge class_registry, definitions, Add DEFAULT_CHART_SAVE_FOLDER var.
45acb50 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Slight reformat. Add APP_SETTINGS, APP_DEFAULT_CHART_SAVE_FOLDER paths.
cd311cb 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add select_folder_dialogue. Rename filename to filepath_str.
aea4281 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Rename class_registry import to definitions.
13ab767 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add settings.py, user_default_chart_save_location functions, app_init.
c1cfd72 
App_init function to create of settings.py dynamically on app first run,
option to set default_chart_save_location or to default, loading setting
on app run functionality. Function can be extended for other runtime
configuration purposes in future.

Move data_folder_check to initialise_app.

Combine app_config and data_folder_check in app_init funct.

Rename class_registry call to call from definitions.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Correct failing import. Fixes #91.
ed29156 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add test settings.py path. Remove unnecessary image_data path.
d13e288 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Pass over tests failing due to new setup save folder feature. See #90.
ced8830 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Remove depreciated IMAGE_DATA folder creation.
ecc742e 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Rename test_app_main to reflect moved data_folder_check function.
18d9a4d 
Remove depreciated IMAGE_DATA folder creation test.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Refactor clear_screen to take variable argument.
c9cbdc8 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Move main_menu into folder UI_menus, add settings_menu.py
d3c8132 
Add settings menu to main_menu, UI for resetting chart save folder.
Change run_app main_menu import.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Remove superfluous import alias as self.
526560c 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Use pathlib.Path to ensure saved value has uniform separators.
8391ca7 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add folder set runtime var initialisation, user feedback.
eaa1858 
Remove superfluous debug print.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Codestyle two spaces before comment.
9dde26f 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Initialise chosen_option, fixed bad docstring return value, PEP8 fixes.
54361c3 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Move helper UI_functions.py to UI_menus folder.
eae30c4 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
PEP8 remove extra space before operator
1d57814 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Create save_as_dialogue. Add start_dir arg to select_file_dialogue.
f7bbfe6 
Rename initial_dir arg in select_folder_dialogue to start_dir for
consistency with other functions.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Create __init__.py.
2d5d70a 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add class chart_save_folder to setup_class_storage.
73b4686 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add start_dir param above app folder to avatar_file_dialogue.
bc930d2 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add chart_default_filename to class_data_dict, save chart to chart_data.
4d86c83 
Safe filename form of chart_name used to save chart_data_file and to
save a copy of the chart image in classname/chart_data with it.
Also used to supply a suggested filename to chart save dialogue.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add save_chart_image func, UI for user select.
66ad4db 
Prompts user for name, location for chart image, using default chart
save location as initial dialogue location.
Saves image in user location with user supplied name, and saves a copy
in class chart_data with filename safe chart_name.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
User set chart save folder defaults UI location to folder above app.
b94e74e 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Docstring, PEP8 fix.
724d26e 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Fix broken test by mocking out DEFAULT_CHART_SAVE_FOLDER.
64df9ca 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Slight reordering of return values to match dict assignment, clarity.
d9cfc47 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Various docstring, PEP8, comment improvements.
eb29469 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add corrected Coveralls coverage calculation.
58530a7 
Remove false Python 3.6 testing on circleci note.

Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add circleci badge to README.
279f082 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Merge branch 'development' into new_CI_coverage
9bf0e9c
@toonarmycaptain
Correct indentation.
864cb60 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add circleci testing, correct coveralls coverage calculation. (#97)
651dd42 
* Add Python 3.7 testing via circleci. 
* Correct Coveralls coverage calculation by removing test_suite, venv from coveragerc.
* Add circleci badge to README.
@toonarmycaptain
Add comment, PEP8 blank line at end of file.
dc7aec6 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Update neglected CHANGELOG with recent changes.
40ed6b0 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Move removed elements to Removed tag.
b0cc0ee 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add Code Cimate Maintainability badge.
50dd9ae
@toonarmycaptain
Add Code Climate, links.
6962d30
@toonarmycaptain
Add Codebeat, note in CHANGELOG, badge in README, ignore test code.
92e4460 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add missing slash to .codebeatignore.
27d7d27 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Merge branch 'development' into new_CI_coverage
b5daf35
@toonarmycaptain
Add Codebeat coverage, badge, .codebeatignore (#103)
c0408df 
* Add Codebeat, note in CHANGELOG, badge in README, ignore test code.
@toonarmycaptain
Reformat - each badge on a newline.
31e97d5 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Add Codeship badge.
a2b5015 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Merge remote-tracking branch 'origin/new_CI_coverage' into new_CI_cov…
b693f3f 
…erage

# Conflicts:
#	README.md
@toonarmycaptain
Add Codeship note in CHANGELOG
a45b8c0 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Merge branch 'development' into new_CI_coverage
8dbfd97
@toonarmycaptain
Merge pull request #104 from toonarmycaptain/new_CI_coverage
4c2f81a 
Add Codeship CI
@toonarmycaptain
Bump version number, changelog for release: [0.2.0-alpha] - 2018-12-31
f98fc2a 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain
Merge remote-tracking branch 'origin/development' into development
f000f49
@toonarmycaptain
Spelling and minor clarity edits.
733cfb9 
Signed-off-by: David <toonarmycaptain@hotmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 355

  • 82 of 222 (36.94%) changed or added relevant lines in 15 files are covered.
  • 62 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-31.8%) to 40.468%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app_main.py 4 7 57.14%
dionysus_app/class_functions.py 4 8 50.0%
dionysus_app/class_registry_functions.py 2 6 33.33%
dionysus_app/initialise_app.py 11 15 73.33%
dionysus_app/chart_generator/create_chart.py 1 6 16.67%
dionysus_app/chart_generator/generate_image.py 8 20 40.0%
dionysus_app/UI_menus/settings_menu.py 6 29 20.69%
dionysus_app/UI_menus/UI_functions.py 11 51 21.57%
dionysus_app/settings_functions.py 19 64 29.69%
Files with Coverage Reduction New Missed Lines %
dionysus_app/chart_generator/create_chart.py 2 41.46%
app_main.py 3 56.25%
dionysus_app/class_registry_functions.py 11 44.44%
dionysus_app/class_functions.py 46 28.03%
Totals Coverage Status
Change from base Build 284: -31.8%
Covered Lines: 242
Relevant Lines: 598
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 357

  • 82 of 222 (36.94%) changed or added relevant lines in 15 files are covered.
  • 62 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-31.8%) to 40.468%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app_main.py 4 7 57.14%
dionysus_app/class_functions.py 4 8 50.0%
dionysus_app/class_registry_functions.py 2 6 33.33%
dionysus_app/initialise_app.py 11 15 73.33%
dionysus_app/chart_generator/create_chart.py 1 6 16.67%
dionysus_app/chart_generator/generate_image.py 8 20 40.0%
dionysus_app/UI_menus/settings_menu.py 6 29 20.69%
dionysus_app/UI_menus/UI_functions.py 11 51 21.57%
dionysus_app/settings_functions.py 19 64 29.69%
Files with Coverage Reduction New Missed Lines %
dionysus_app/chart_generator/create_chart.py 2 41.46%
app_main.py 3 56.25%
dionysus_app/class_registry_functions.py 11 44.44%
dionysus_app/class_functions.py 46 28.03%
Totals Coverage Status
Change from base Build 284: -31.8%
Covered Lines: 242
Relevant Lines: 598
💛 - Coveralls

@toonarmycaptain
Add final newline.
1a3b7be 
Signed-off-by: David <toonarmycaptain@hotmail.com>
Repository owner deleted a comment Jan 1, 2019
@toonarmycaptain
Copy link
Owner Author

Coverage decreased because test coverage metric is now accurate.

Code climate is mostly having issues with the test suite. Should be ignored on next analysis.

Better Code Hub's issue is too big interfaces for the file dialogues - opened issue #106

@toonarmycaptain toonarmycaptain merged commit bdada70 into master Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toonarmycaptain @coveralls