fix pattern and toString, then enhance sign() method #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pattern
Fixing
RFC_2617_PARAM
to be able to parse timestamp with a,
separated decimal part (for example, for french people)Fix Signature.toString()
I don't understand why
created
andexpires
disappeared from Signature string if algo is not HS2019.What I propose is to only add those informations if not null and if headers contains
(created)
or(expires)
Add a new Signer.sign() method
Create a new
public Signature sign(final String method, final String uri, final Map<String, String> headers, Long created, Long expires) throws IOException
The idea here is to provide a way to sign giving the choice of created and expires timestamp.
It is useful for a validation case from a string, you are able to regenerate a signature from input and keep control on those two timestamps.