Fix: parse DEFAULT in VALUES clause into a Var #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
Nov 26, 2024
| @@ -198,6 +198,7 @@ class Presto(Dialect): | |||
| TYPED_DIVISION = True | |||
| TABLESAMPLE_SIZE_IS_PERCENT = True | |||
| LOG_BASE_FIRST: t.Optional[bool] = None | |||
| SUPPORTS_VALUES_DEFAULT = False | |||
There was a problem hiding this comment.
Both Presto and Trino treat DEFAULT as an identifier: I tried running the issue's INSERT and got an identifier resolution error back. Only those two out of the engines I tested had this behavior, the other engines treat DEFAULT as a special keyword in the context of a VALUES clause.
tobymao
approved these changes
Nov 26, 2024
georgesittas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4446