Created a History Command #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #4 |
tmathmeyer
requested changes
Nov 24, 2020
src/kernel/kshell.c
Outdated
| @@ -107,6 +107,9 @@ bool alt_mode = false; | |||
| bool ctrl_mode = false; | |||
| bool super_mode = false; | |||
|
|
|||
| char history_data[100][RDL_SIZE]; | |||
| uint8_t tot_cmds=0; | |||
There was a problem hiding this comment.
I'd prefer you keep this in some sort of dynamic data structure, rather than a list - not just for cleanliness, but because this implementation is rife with data overflow opportunities. - for instance, you never bounds check on tot_cmds
There was a problem hiding this comment.
I have created a dynamic list to resolve the overflow problem.
src/kernel/kshell.c
Outdated
| else if (!strncmp(run, "history", 7)){ | ||
| for(int i=0;i<tot_cmds;i++){ | ||
| write_num(i+1); | ||
| kprintf(" %05s",history_data[i]); |
There was a problem hiding this comment.
please use 1 kprintf for this line.
There was a problem hiding this comment.
Compressed my code to 1 line kprintf.
src/kernel/kshell.c
Outdated
Comment on lines
197
to
200
| for (i = 0; i < rdl_index; i++) | ||
| { | ||
| history_data[tot_cmds][i]=readline[i]; | ||
| } |
There was a problem hiding this comment.
Copied data using memcpy and reduced the no. of lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created the history command for SOS, which is not present. The command and output will look like below...
