Merge pull request #61 from mt-caret/uniform-and-float-arrays #248
Annotations
14 warnings
the following explicit lifetimes could be elided: 'b:
src/memory.rs#L117
warning: the following explicit lifetimes could be elided: 'b
--> src/memory.rs:117:24
|
117 | pub fn alloc_error<'a, 'b, A, Err>(
| ^^
118 | cr: &'a mut OCamlRuntime,
119 | err: OCamlRef<'b, Err>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
117 ~ pub fn alloc_error<'a, A, Err>(
118 | cr: &'a mut OCamlRuntime,
119 ~ err: OCamlRef<'_, Err>,
|
|
the following explicit lifetimes could be elided: 'b:
src/memory.rs#L106
warning: the following explicit lifetimes could be elided: 'b
--> src/memory.rs:106:21
|
106 | pub fn alloc_ok<'a, 'b, A, Err>(
| ^^
107 | cr: &'a mut OCamlRuntime,
108 | value: OCamlRef<'b, A>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
106 ~ pub fn alloc_ok<'a, A, Err>(
107 | cr: &'a mut OCamlRuntime,
108 ~ value: OCamlRef<'_, A>,
|
|
the following explicit lifetimes could be elided: 'b:
src/memory.rs#L95
warning: the following explicit lifetimes could be elided: 'b
--> src/memory.rs:95:23
|
95 | pub fn alloc_some<'a, 'b, A>(
| ^^
96 | cr: &'a mut OCamlRuntime,
97 | value: OCamlRef<'b, A>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
95 ~ pub fn alloc_some<'a, A>(
96 | cr: &'a mut OCamlRuntime,
97 ~ value: OCamlRef<'_, A>,
|
|
docs for unsafe trait missing `# Safety` section:
src/conv/to_ocaml.rs#L25
warning: docs for unsafe trait missing `# Safety` section
--> src/conv/to_ocaml.rs:25:1
|
25 | pub unsafe trait ToOCaml<T> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
|
docs for unsafe trait missing `# Safety` section:
src/conv/from_ocaml.rs#L14
warning: docs for unsafe trait missing `# Safety` section
--> src/conv/from_ocaml.rs:14:1
|
14 | pub unsafe trait FromOCaml<T> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
mutable reference of mutable static is discouraged:
src/runtime.rs#L60
warning: mutable reference of mutable static is discouraged
--> src/runtime.rs:60:9
|
60 | &mut RUNTIME
| ^^^^^^^^^^^^ mutable reference of mutable static
|
= note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
= note: reference of mutable static is a hard error from 2024 edition
= note: mutable statics can be written to by multiple threads: aliasing violations or data races will cause undefined behavior
= note: `#[warn(static_mut_ref)]` on by default
help: mutable references are dangerous since if there's any other pointer or reference used for that static while the reference lives, that's UB; use `addr_of_mut!` instead to create a raw pointer
|
60 | addr_of_mut!(RUNTIME)
|
|
unused imports: `local_roots as ocaml_sys_local_roots`, `set_local_roots as ocaml_sys_set_local_roots`:
src/memory.rs#L15
warning: unused imports: `local_roots as ocaml_sys_local_roots`, `set_local_roots as ocaml_sys_set_local_roots`
--> src/memory.rs:15:17
|
15 | caml_alloc, local_roots as ocaml_sys_local_roots, set_local_roots as ocaml_sys_set_local_roots,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `caml_alloc`:
src/conv/from_ocaml.rs#L11
warning: unused import: `caml_alloc`
--> src/conv/from_ocaml.rs:11:17
|
11 | use ocaml_sys::{caml_alloc, caml_sys_double_field};
| ^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
clippy (ubuntu-latest, 4.14.1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy (ubuntu-latest, 4.14.1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy (ubuntu-latest, 4.14.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (ubuntu-latest, 4.14.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (ubuntu-latest, 4.14.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (ubuntu-latest, 4.14.1)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|