Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean code #39

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Clean code #39

wants to merge 52 commits into from

Commits on Aug 22, 2020

  1. Initial commit

    @titus-ong
    titus-ong committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    236eb88 View commit details
    Browse the repository at this point in the history

  2. Initial commit

    @titus-ong
    titus-ong committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    a237ef6 View commit details
    Browse the repository at this point in the history

  3. Added Note class and as_int method

    @titus-ong
    titus-ong committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    6052672 View commit details
    Browse the repository at this point in the history

  4. Added symbol-int converters

    @titus-ong
    titus-ong committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    5dad0ce View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2020

  1. Initial commit

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    d8fb051 View commit details
    Browse the repository at this point in the history

  2. Made examples naming clearer

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    adac790 View commit details
    Browse the repository at this point in the history

  3. Included transpose methods

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    e31a5d0 View commit details
    Browse the repository at this point in the history

  4. Abstracted NotationParser class out into separate file

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    4361f6f View commit details
    Browse the repository at this point in the history

  5. Included mode patterns

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    59c68e4 View commit details
    Browse the repository at this point in the history

  6. Initial commit

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    468a248 View commit details
    Browse the repository at this point in the history

  7. Rename group count method and change pattern to property

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    8a6b46f View commit details
    Browse the repository at this point in the history

  8. Update test with method name change

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    1e7911b View commit details
    Browse the repository at this point in the history

  9. Included docstring for Note

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    5ce4875 View commit details
    Browse the repository at this point in the history

  10. Included Mode, Key, and their notation parsers

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    174932c View commit details
    Browse the repository at this point in the history

  11. Added check for valid symbol

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    38247d8 View commit details
    Browse the repository at this point in the history

  12. Added symbol pattern

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    f6a10ea View commit details
    Browse the repository at this point in the history

  13. Test for valid symbol

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    9481819 View commit details
    Browse the repository at this point in the history

  14. Initial commit

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    e6a51d0 View commit details
    Browse the repository at this point in the history

  15. Create static method for getting number of groups from regex pattern

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    d024330 View commit details
    Browse the repository at this point in the history

  16. Minor ordering change

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    da4ac02 View commit details
    Browse the repository at this point in the history

  17. Added from_components class method

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    7107fdd View commit details
    Browse the repository at this point in the history

  18. Minor name changes

    @titus-ong
    titus-ong committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    b035078 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Added check for set_mode to have at least one argument

    @titus-ong
    titus-ong committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    1fb661e View commit details
    Browse the repository at this point in the history

  2. Minor formatting changes to error messages

    @titus-ong
    titus-ong committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    3b1729c View commit details
    Browse the repository at this point in the history

  3. Fix some references

    @titus-ong
    titus-ong committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    def3675 View commit details
    Browse the repository at this point in the history

  4. Updated docs

    @titus-ong
    titus-ong committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    ead0be2 View commit details
    Browse the repository at this point in the history

  5. Fix method references

    @titus-ong
    titus-ong committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    cf92648 View commit details
    Browse the repository at this point in the history

  6. Initial commit for scales

    @titus-ong
    titus-ong committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    9e22023 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Change submode and mode to enums for easier comparison

    @titus-ong
    titus-ong committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    cd056ef View commit details
    Browse the repository at this point in the history

  2. Minor changes to repr to be more in line with Python's standard repr

    @titus-ong
    titus-ong committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    1b1bb2e View commit details
    Browse the repository at this point in the history

  3. Remove unused auto function

    @titus-ong
    titus-ong committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    bb9b2cc View commit details
    Browse the repository at this point in the history

  4. Included docstring for enums

    @titus-ong
    titus-ong committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    5740c9f View commit details
    Browse the repository at this point in the history

  5. Updated docstrings and included step_pattern property for mode and su… 

    …bmode enums
    @titus-ong
    titus-ong committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    5d732f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. minor name changes

    @titus-ong
    titus-ong committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0a9a5ca View commit details
    Browse the repository at this point in the history

  2. Change letter and symbol to enums, and abstracted symbolful classes i… 

    …nto abstract class
    @titus-ong
    titus-ong committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    c2f3233 View commit details
    Browse the repository at this point in the history

  3. Added more template-specific tests

    @titus-ong
    titus-ong committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    618330e View commit details
    Browse the repository at this point in the history

  4. Moved mode and submode enums to separate files for other modules to a… 

    …ccess them easily
    @titus-ong
    titus-ong committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f0f4b5b View commit details
    Browse the repository at this point in the history

  5. Made abstract classes more formalised (cannot be instantiated without… 

    … overriding abstract methods)
    @titus-ong
    titus-ong committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    42d4028 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Changed regex flags not to ignore case by default (only key notation … 

    …requires ignoring case)
    @titus-ong
    titus-ong committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    010ec94 View commit details
    Browse the repository at this point in the history

  2. Remove tests for enums

    @titus-ong
    titus-ong committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    80b6916 View commit details
    Browse the repository at this point in the history

  3. moved enums into components folders for cleaner folder structure

    @titus-ong
    titus-ong committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    f8310d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. removed value description for enums - they are explained in the methods

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    bf6196a View commit details
    Browse the repository at this point in the history

  2. minor formatting edit

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    42830e2 View commit details
    Browse the repository at this point in the history

  3. Initial commit for quality enums

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    d2555d5 View commit details
    Browse the repository at this point in the history

  4. Included test for creating scale degrees for basequality enum

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    ed55c6f View commit details
    Browse the repository at this point in the history

  5. Initial commit for matching power chords

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    abf8c8f View commit details
    Browse the repository at this point in the history

  6. Added more regex patterns and tests for the more complex ones

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    51d1793 View commit details
    Browse the repository at this point in the history

  7. Initial commit for suspended chords

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    613155c View commit details
    Browse the repository at this point in the history

  8. Initial commit for triads

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    5a3bb8b View commit details
    Browse the repository at this point in the history

  9. Included power into base quality

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    4539183 View commit details
    Browse the repository at this point in the history

  10. Fix power regex result

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    0df9c84 View commit details
    Browse the repository at this point in the history

  11. Change roman converter to accept the roman notation

    @titus-ong
    titus-ong committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    7d0f29d View commit details
    Browse the repository at this point in the history