Skip to content

Commit

Permalink
Allow column_name and arrays in column options (ildus#93)
Browse files Browse the repository at this point in the history
Both column_name and arrays are already supported as options in https://github.com/gh56123/clickhouse_fdw/blob/master/src/custom_types.c#L522-L539

Before this patch:

```
ALTER FOREIGN TABLE foreign_table ALTER COLUMN pg_column_name OPTIONS (
 	    column_name 'column_name_as_in_clickhouse'
 	);
ERROR:  invalid option "column_name"
HINT:  Valid options in this context are: aggregatefunction, simpleaggregatefunction
```
  • Loading branch information
gh56123 authored and Jesús Botella committed Sep 19, 2024
1 parent ee52588 commit 5646baf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/option.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ InitChFdwOptions(void)
{"driver", ForeignServerRelationId, false},
{"aggregatefunction", AttributeRelationId, false},
{"simpleaggregatefunction", AttributeRelationId, false},
{"column_name", AttributeRelationId, false},
{"arrays", AttributeRelationId, false},
{NULL, InvalidOid, false}
};

Expand Down

0 comments on commit 5646baf

Please sign in to comment.