feat: remove the prompt to keep project level wrapper (false by def…

…ault)
tinesoft · Jun 19, 2024 · d3b89b3 · d3b89b3
1 parent bc523a2
commit d3b89b3
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 36 deletions.
diff --git a/packages/nx-ktor/src/generators/preset/schema.json b/packages/nx-ktor/src/generators/preset/schema.json
@@ -163,7 +163,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/dZelN for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "ktorInitializrUrl": {
       "type": "string",

diff --git a/packages/nx-ktor/src/generators/project/lib/prompt-multi-module-support.ts b/packages/nx-ktor/src/generators/project/lib/prompt-multi-module-support.ts
@@ -37,13 +37,7 @@ export async function promptForMultiModuleSupport(tree: Tree, options: Normalize
                     initial: `${options.projectName}-parent`
                 }).then((a) => a['parentModuleName'])).replace(/\//g, '-');
 
-                options.keepProjectLevelWrapper = await prompt({
-                    name: 'keepProjectLevelWrapper',
-                    message:
-                        `A root ${buildSystemName} wrapper will be added in the root module '${options.parentModuleName}'. Do you want to keep the one in the generated child module '${options.projectName}'?`,
-                    type: 'confirm',
-                    initial: false
-                }).then((a) => a['keepProjectLevelWrapper']);
+                options.keepProjectLevelWrapper ??= false;
             }
         }
         else {

diff --git a/packages/nx-ktor/src/generators/project/schema.json b/packages/nx-ktor/src/generators/project/schema.json
@@ -158,7 +158,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/dZelN for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "ktorInitializrUrl": {
       "type": "string",

diff --git a/packages/nx-micronaut/src/generators/preset/schema.json b/packages/nx-micronaut/src/generators/preset/schema.json
@@ -227,7 +227,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/ov0Y9 for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "micronautLaunchUrl": {
       "type": "string",

diff --git a/packages/nx-micronaut/src/generators/project/lib/prompt-multi-module-support.ts b/packages/nx-micronaut/src/generators/project/lib/prompt-multi-module-support.ts
@@ -36,13 +36,7 @@ export async function promptForMultiModuleSupport(tree: Tree, options: Normalize
                     initial: `${options.projectName}-parent`
                 }).then((a) => a['parentModuleName'])).replace(/\//g, '-');
 
-                options.keepProjectLevelWrapper = await prompt({
-                    name: 'keepProjectLevelWrapper',
-                    message:
-                        `A root ${buildSystemName} wrapper will be added in the root module '${options.parentModuleName}'. Do you want to keep the one in the generated child module '${options.projectName}'?`,
-                    type: 'confirm',
-                    initial: false
-                }).then((a) => a['keepProjectLevelWrapper']);
+                options.keepProjectLevelWrapper ??= false;
             }
         }
         else {

diff --git a/packages/nx-micronaut/src/generators/project/schema.json b/packages/nx-micronaut/src/generators/project/schema.json
@@ -231,7 +231,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/ov0Y9 for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "micronautLaunchUrl": {
       "type": "string",

diff --git a/packages/nx-quarkus/src/generators/preset/schema.json b/packages/nx-quarkus/src/generators/preset/schema.json
@@ -127,7 +127,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/TmKF- for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "quarkusInitializerUrl": {
       "type": "string",

diff --git a/packages/nx-quarkus/src/generators/project/lib/prompt-multi-module-support.ts b/packages/nx-quarkus/src/generators/project/lib/prompt-multi-module-support.ts
@@ -36,13 +36,7 @@ export async function promptForMultiModuleSupport(tree: Tree, options: Normalize
                     initial: `${options.projectName}-parent`
                 }).then((a) => a['parentModuleName'])).replace(/\//g, '-');
 
-                options.keepProjectLevelWrapper = await prompt({
-                    name: 'keepProjectLevelWrapper',
-                    message:
-                        `A root ${buildSystemName} wrapper will be added in the root module '${options.parentModuleName}'. Do you want to keep the one in the generated child module '${options.projectName}'?`,
-                    type: 'confirm',
-                    initial: false
-                }).then((a) => a['keepProjectLevelWrapper']);
+                options.keepProjectLevelWrapper ??= false;
             }
         }
         else {

diff --git a/packages/nx-quarkus/src/generators/project/schema.json b/packages/nx-quarkus/src/generators/project/schema.json
@@ -131,7 +131,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/TmKF- for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "quarkusInitializerUrl": {
       "type": "string",

diff --git a/packages/nx-spring-boot/src/generators/preset/schema.json b/packages/nx-spring-boot/src/generators/preset/schema.json
@@ -217,7 +217,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/yvsp1 for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "springInitializerUrl": {
       "type": "string",

diff --git a/packages/nx-spring-boot/src/generators/project/lib/prompt-multi-module-support.ts b/packages/nx-spring-boot/src/generators/project/lib/prompt-multi-module-support.ts
@@ -35,13 +35,7 @@ export async function promptForMultiModuleSupport(tree: Tree, options: Normalize
                     initial: `${options.projectName}-parent`
                 }).then((a) => a['multiModuleName'])).replace(/\//g, '-');
 
-                options.keepProjectLevelWrapper = await prompt({
-                    name: 'keepProjectLevelBuildSystemWrapper',
-                    message:
-                        `A root ${buildSystemName} wrapper will be added in the root module '${options.parentModuleName}'. Do you want to keep the one in the generated child module '${options.projectName}'?`,
-                    type: 'confirm',
-                    initial: false
-                }).then((a) => a['keepProjectLevelBuildSystemWrapper']);
+                options.keepProjectLevelWrapper ??= false;
             }
         }
         else {

diff --git a/packages/nx-spring-boot/src/generators/project/schema.json b/packages/nx-spring-boot/src/generators/project/schema.json
@@ -200,7 +200,7 @@
     "keepProjectLevelWrapper": {
       "description": "Keep the `Maven` or `Gradle` wrapper files from child project (when generating a multi-module project). Follow this guide https://t.ly/yvsp1 for more information.",
       "type": "boolean",
-      "default": true
+      "default": false
     },
     "springInitializerUrl": {
       "type": "string",