Allow configuration of a data size before a flush occurs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2024 23:06
Currently the client gets flushed every command (which is every pixel) this is inefficient since every tcp package can hold multiple pixel (the exact number depends on the network and mtu). This patch gives 3 options for setting a FlushMode: - Manual > Never flush - Commands > Flush after a number of commands (like Pixels) - Bytes > Flush when a package size is reached. Further a flush_size has to be set. Example: To run in the current mode where a flush occurs per pixel: - FlushMode::Command,1 To flush at a size of 1500 Bytes (which is a commonly used mtu): - FlushMode:Bytes,1 Further a method is introduced for the client to flush manually
This exposes the previously introduced Flush Mode to the List of configurable arguments. If no argument is confiured here, there will a flush occur every command/pixel as was the case before. Examples: Flush every single Pixel as it is the default: pixelpwnr '<socket>' --image=cat.png -w 500 -h 500 -x 0 -y 0 --flushmode commands --flushsize 1 Flush after 1500 bytes (commonly used mtu) pixelpwnr '<socket>' --image=cat.png -w 500 -h 500 -x 0 -y 0 --flushmode bytes --flushsize 1500
timvisee
reviewed
Mar 13, 2024
Co-authored-by: Tim Visée <tim+github@visee.me>
|
sry it took my so long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the client gets flushed every command (which is every pixel) this is inefficient since every tcp package can hold multiple pixel (the exact number depends on the network and mtu).
This patch gives 3 options for setting a FlushMode:
- Manual > Never flush
- Commands > Flush after a number of commands (like Pixels)
- Bytes > Flush when a package size is reached.