Add workaround for pg_depend bug in PG < 15.4 #7508
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL versions prior to 15.4 didn't properly update object dependencies when setting a new access method on a table. The fix for the bug is found in this commit: postgres/postgres@97d8910 The `hypercore_create` test failed on buggy PG versions (e.g., 15.0) due to wrong contents of pg_depend showing up in test output when converting a table from Hypercore TAM back to regular heap. This change adds a workaround that updates pg_depend with the correct information when compiling against PG versions that suffer from the bug.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7508 +/- ##
==========================================
+ Coverage 80.06% 82.13% +2.07%
==========================================
Files 190 230 +40
Lines 37181 43190 +6009
Branches 9450 10868 +1418
==========================================
+ Hits 29770 35476 +5706
- Misses 2997 3388 +391
+ Partials 4414 4326 -88 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL versions prior to 15.4 didn't properly update object dependencies when setting a new access method on a table. The fix for the bug is found in this commit:
postgres/postgres@97d8910
The
hypercore_createtest failed on buggy PG versions (e.g., 15.0) due to wrong contents of pg_depend showing up in test output when converting a table from Hypercore TAM back to regular heap.This change adds a workaround that updates pg_depend with the correct information when compiling against PG versions that suffer from the bug.
Disable-check: force-changelog-file
Disable-check: approval-count