Add firefox as supported browser

[nielsvanvelzen]

I recently switched to Firefox as my primary browser and was surprised to see Tidepool blocking browsers without any clear reason. As explained in the mentioned issues, if there are specific functionalities that require Chrome you should use feature testing instead of blocking a complete browser. This is a really dark UX pattern.

This PR adds Firefox to the "supported browsers" list, which obviously is still a hack because Tidepool still blocks browsers for not being Chrome.

Fixes #418
Fixes #1029

[krystophv]

Thanks for this, you can follow along with our efforts to expand browser support here: https://tidepool.atlassian.net/browse/WEB-1806

[nielsvanvelzen]

Thanks for the fast response. It's great to see Firefox support is already in progress. The linked issues didn't have any official responses so I wasn't aware of that. It does look like the last changes to the ticket happened back in August, does that mean the project is currently on hold?

Would it be possible to create some kind of "ignore this warning" button in the meantime as an easy-win for the Firefox users?

[krystophv]

The linked issue has many sub-tasks which describe testing and bug reports from cross-browser verification. Firefox support is the next priority and, to my knowledge, the testing and bug fixes for Firefox are now complete. All that remains is the task to adjust our supported browser list and page. I'll bring this up in the next sprint prioritization for consideration.

We cannot add a warning bypass for browsers that we haven't yet verified and documented functionality for.

[nielsvanvelzen]

Thanks for the responses, appreciate the efforts! I'll close the PR so you guys can add the support properly.

[vitawasalreadytaken]

Hi, apologies if I'm hijacking an old thread, but this seems to be the one place on GitHub which aggregates several duplicate issues on the topic of browser compatibility.

For what it's worth, I'd like to express support for this bugfix as well. I deliberately use the word "bugfix" rather than "feature". Google Chrome is a browser that comes with serious privacy issues (just like its parent company, and that's no accident). I am disappointed that I am being forced to use it if I want to use Tidepool. I am a big fan of Tidepool's open-source ethos, and this odd privacy-harming restriction doesn't quite fit it 😕

I found some quite recent updates on child issues of https://tidepool.atlassian.net/browse/WEB-1806, so it seems there is some progress on this. Perhaps the delivery could be sped up by expanding browser support one by one? 🙏

(I am aware that I can circumvent this block by modifying the User-Agent string in the meantime.)

Thank you for your work – I hope this doesn't come across as ungrateful. It is amazing how much quality software you put out there for free use!