Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making dot15d4 no_std and Embassy compatible #8

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

SamClercky
Copy link
Contributor

@SamClercky SamClercky commented Mar 10, 2024

Initial work on #7. This PR includes:

  • Decoupling of tracing
  • CI test to check that crate stays compatible with no_std and no_alloc

Fixes: #7

@SamClercky SamClercky changed the title Making dot15d4 no_std and Embassy compatible Draft: Making dot15d4 no_std and Embassy compatible Mar 11, 2024
@thvdveld thvdveld marked this pull request as draft March 11, 2024 14:46
@thvdveld
Copy link
Owner

thvdveld commented Mar 11, 2024

You need to add a licence to ensure_no_std (the same as all the rest).

I think it's better to remove ensore_no_std from the workspace in Cargo.toml, and just add a job in CI that tries to compile it. Try to compile it for thumbv7m-none-eabi, as this is the target for the nRF52840.

Could you also rename ensure_no_std to ensure-no-std?

ensure_no_std/Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 59.99%. Comparing base (1647135) to head (ceca885).

Files Patch % Lines
dot15d4/src/frame/ie/nested.rs 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   59.91%   59.99%   +0.08%     
==========================================
  Files          31       31              
  Lines        3622     3617       -5     
==========================================
  Hits         2170     2170              
+ Misses       1452     1447       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamClercky SamClercky marked this pull request as ready for review March 12, 2024 10:52
@SamClercky SamClercky changed the title Draft: Making dot15d4 no_std and Embassy compatible Making dot15d4 no_std and Embassy compatible Mar 12, 2024
@thvdveld thvdveld merged commit 9df6dce into thvdveld:main Mar 12, 2024
7 of 8 checks passed
@SamClercky SamClercky deleted the no_std_compat branch March 12, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing not compatible with Embassy
2 participants