test

sstables/sstable_iterator.go

@@ -84,6 +84,9 @@ func (it *SSTableFullScanIterator) Next() ([]byte, []byte, error) {
 		}
 	}
 
+	// TODO(thomas): how do we know whether we need to skip here, based on the offset?
+	// TODO(thomas):
+
 	next, err := it.dataReader.ReadNext()
 	if err != nil {
 		return nil, nil, err

sstables/sstable_writer_test.go

@@ -152,11 +152,10 @@ func TestFailedIndexAppend(t *testing.T) {
 	require.NoError(t, writer.WriteNext(intToByteSlice(44), intToByteSlice(45)))
 	require.NoError(t, writer.Close())
 
-	reader, _ := getFullScanIterator(t, writer.opts.basePath)
+	reader, it := getFullScanIterator(t, writer.opts.basePath)
 	defer closeReader(t, reader)
 
-	// TODO(thomas): this is failing, as the "optimized" iterator is not skipping partial records
-	// assertIteratorMatchesSlice(t, it, []int{42, 44})
+	assertIteratorMatchesSlice(t, it, []int{42, 44})
 	assertContentMatchesSlice(t, reader, []int{42, 44})
 	_, err = reader.Get(intToByteSlice(43))
 	require.Equal(t, NotFound, err)