Async RandomAccessReader and zips within zips #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport create a reader implementation for stored entries within a zip file, thereby supporting stored zips within zips. Add a test for the new classes based on the existing range-test. Related to thejoshwolfe#89
|
|
||
| exports.runTest = runTest; | ||
|
|
||
| // zipfile obtained via: |
There was a problem hiding this comment.
thanks for being conscientious enough to add tests 👍 . However, I think we can test this functionality in a much simpler way.
There was a problem hiding this comment.
Fair enough. I wanted to be certain that ranges within what is basically another range (the zip in the zip) worked properly.
… non-async createReadStream/readStreamCallback calls, but not after running an async createReadStream call. Instead, wait for that call's callback has executed readStreamCallback before unref'ing.
|
My main goal was backwards compatibility with existing code and RandomAccessReader implementations while adding support for accessing a stored zip within a zip without having to read the whole thing into a buffer or temp file. Looking forward to seeing your approach to solving the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for an asynchronous RandomAccessReader, and using that support create a reader implementation for stored entries within a zip file, thereby supporting stored zips within zips. Add a test for the new classes based on the existing range-test.
Related to #89