Use puppet-openssl and remove use of katello-certs-tool #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
May 21, 2024
| @@ -59,7 +59,7 @@ | |||
| String $city = $certs::city, | |||
| String $org = $certs::org, | |||
| String $org_unit = $certs::org_unit, | |||
| String $expiration = $certs::expiration, | |||
| Variant[Integer, String] $expiration = $certs::expiration, | |||
There was a problem hiding this comment.
I'd be open to a PR that already changes it from Strings to Integers prior to merging this.
Checks? None that I am aware of - do you have ideas of what you are thinking? The riskiest part of this change I believe is to ensure that for existing installations the CA certificate / key / password are not regenerated. I've added a new migration test that uses a copy of what a standard looking katello-certs-tool based generated certificate looks like to check that it does not change. |
ehelms
force-pushed
the
use-puppet-openssl
branch
from
a1ce816
to
99d5f71
Compare
|
I've opened a PR for the puppet-openssl support I am relying on here. (voxpupuli/puppet-openssl#188) |
ehelms
force-pushed
the
use-puppet-openssl
branch
from
99d5f71
to
0e25381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.