Fixes #37250 - Ensure js tests are executed on default branch

[dosas]

I would like to address the situation that a change in foreman was breaking this plugin and it went unnoticed for nearly two months.

The best way to fix this integration problem would probably be nightly test runs.

This PR suggests to at least run the js tests when a branch is merged into (pushed to) master. This way possible errors are recognized by a failing default branch and development on PRs is not blocked by 'slow' js tests.

What do you think @nofaralfasi @evgeni ?

Obviously this requires #698 to work.

[evgeni]

I would prefer if we also would run JS tests on every PR, not only those touching webpack.
(people tend to ignore GHA results for pushes)

[dosas]

@evgeni also fine with me (y)

[nofaralfasi]

@dosas can you please update and rebase?

[dosas]

@dosas can you please update and rebase?

done

[evgeni]

Node JS 12 tests fail as Core doesn't support Node 12 for a while now ;)

[evgeni]

As an alternative, how about #701 that utilizes the shared workflow and uses the "right" node versions ;)

[dosas]

As an alternative, how about #701 that utilizes the shared workflow and uses the "right" node versions ;)

Fine with me but I think that this is mixing two topics into one commit: One is using shared GHA and the other is when to execute the tests

[evgeni]

True. We can merge this one and then rebase #701 ontop.

@nofaralfasi ok?

[nofaralfasi]

True. We can merge this one and then rebase #701 ontop.

@nofaralfasi ok?

Yes please

[dosas]

@evgeni since #701 was already merged with these changes we can close this, right?

[evgeni]

I agree