Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old reference to foreman_ansible_core #679

Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 10, 2024

Fixes: a9f58ca

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's be rid of it

@adamruzicka
Copy link
Contributor

Ah, needs a rebase now

Fixes: a9f58ca ("Fixes #32564 - Drop foreman_ansible_core (theforeman#411)")
@ekohl ekohl force-pushed the remove-old-foreman_ansible_core-ref branch from 1dd29e5 to b40a993 Compare January 10, 2024 13:51
@ekohl
Copy link
Member Author

ekohl commented Jan 10, 2024

That's why I manually needed to edit the __dir__ commit. I had this first ... Rebased.

@adamruzicka adamruzicka merged commit 8a89d91 into theforeman:master Jan 10, 2024
4 of 5 checks passed
@adamruzicka
Copy link
Contributor

Yeah, sorry about the wrong order, I started with the newest. Thank you @ekohl !

@ekohl ekohl deleted the remove-old-foreman_ansible_core-ref branch January 10, 2024 14:12
@ekohl
Copy link
Member Author

ekohl commented Jan 10, 2024

I didn't notice it myself either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants