-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel11 routes #5883
base: 1.8
Are you sure you want to change the base?
Laravel11 routes #5883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, Ok
No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11. |
change to PR for 1.8 version please check and merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.
change to PR for 1.8 version please check and merge it
Thanks!
Can you rebase the PR? Want to make sure that the tests are passing.
yes please check it proper |
Did you rebase it? Doesn't look like you did. |
b390c58
to
56e674b
Compare
it already rebase please check it and if any issue then please guide me |
Thanks, I can see that you rebased it yesterday. Tests seem to be failing, so we can't go ahead and merge it until tests pass. |
Convert according Laravel 11 routes files
#5846
@soinalastudio
@tnylea and @emptynick
@jonathanribas