Skip to content

Commit

Permalink
feat: remove support for python 3.8 (#108)
Browse files Browse the repository at this point in the history
  • Loading branch information
thatlittleboy authored Nov 24, 2024
1 parent bdfad84 commit bbd220e
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
experimental: [false]
# include:
# - python-version: "3.13-dev"
Expand Down
11 changes: 5 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# pre-commit autoupdate
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
rev: v5.0.0
hooks:
- id: check-added-large-files
args: ["--maxkb=3000"]
Expand All @@ -17,24 +17,23 @@ repos:
- id: check-yaml

- repo: https://github.com/asottile/pyupgrade
rev: v3.16.0
rev: v3.19.0
hooks:
- id: pyupgrade
args: [--py38-plus]
args: [--py39-plus]

- repo: https://github.com/asottile/add-trailing-comma
rev: v3.1.0
hooks:
- id: add-trailing-comma
args: [--py36-plus]

- repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.10.0
hooks:
- id: python-check-blanket-noqa

- repo: https://github.com/psf/black
rev: 24.4.2
rev: 24.10.0
hooks:
- id: black
args: ["--config", "pyproject.toml"]
Expand All @@ -51,7 +50,7 @@ repos:
- id: isort

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.5.0
rev: v0.8.0
hooks:
- id: ruff
types: [python]
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2022 Jeremy Goh
Copyright (c) 2022-2024 Jeremy Goh

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ View all the available images and gifs in the [gallery page](https://thatlittleb

This project is just for personal use, so it is not published on PyPI.

Using [pipx](https://pypa.github.io/pipx/) (Python 3.8+ only) to install directly from github:
Using [pipx](https://pypa.github.io/pipx/) (Python 3.9+ only) to install directly from github:

```shell
$ pipx install git+https://github.com/thatlittleboy/lgtm-db
Expand Down
6 changes: 1 addition & 5 deletions lgtm_db/__init__.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
import argparse
import enum
import sys
from importlib.resources import files
from typing import Optional

import markupsafe

from .__version__ import __version__
from .loader import EmptyGifLoaderError, GifLoader

if sys.version_info >= (3, 9):
from importlib.resources import files
else:
from importlib_resources import files


@enum.unique
class StringOutputFormat(str, enum.Enum):
Expand Down
5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ use_parentheses = true

[tool.ruff]
line-length = 110
force-exclude = true
target-version = "py39"
[tool.ruff.lint]
select = [
# pycodestyle
"E",
Expand All @@ -51,8 +54,6 @@ select = [
"RET505", "RET506", "RET507", "RET508",
]
ignore = ["E501", "F403"]
force-exclude = true
target-version = "py38"

[build-system]
requires = [
Expand Down
3 changes: 1 addition & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ license_files = LICENSE
[options]
packages = find:
include_package_data = True
python_requires = >=3.8
python_requires = >=3.9
install_requires =
markupsafe
pyyaml
importlib_resources;python_version<"3.9"

[options.entry_points]
console_scripts =
Expand Down

0 comments on commit bbd220e

Please sign in to comment.