Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
I've been working with Vue3 / Storybook / Testing Library, and wondered why the props and slots typings work in Storybook. So I took inspiration in Storybook and added typings for the
render
function in vue testing library accordingly.What has been changed
ComponentSlots
byvue-component-type-helpers
by itself was not sufficient enough, since it does not allow slots of type string (e.g.slots: { default: 'Test' }
), that's why we need the Typescript magic that Storybook uses)Reference:
https://github.com/storybookjs/storybook/blob/ba69532715f162567cc17aa3a0de8ca918dfdd2c/code/renderers/vue3/src/public-types.ts#L63-L69