Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the docker tests into a test package #2269

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Minivera
Copy link
Contributor

What does this PR do?

This work has been extracted from #2202 and is related to #2180. See the original PR for the full context and reasoning.

Why is it important?

This will help with the documentation, since all examples will now have the module prefixes.

Related issues

  • Relates to#2180

This work has been extracted from testcontainers#2202 and is related to testcontainers#2180. See the original PR for the full context and reasoning.

This will help with the documentation, since all examples will now have the module prefixes.
@Minivera Minivera requested a review from a team as a code owner February 28, 2024 19:36
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a70d193
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65fc7c9c1267b200082f4796
😎 Deploy Preview https://deploy-preview-2269--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Mar 4, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 4, 2024
docker_test.go Outdated Show resolved Hide resolved
@Minivera Minivera requested a review from mdelapenya March 4, 2024 14:43
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments regarding exposing private functions and vars to the public API. Let's discuss about them before moving on

Thank you!

lifecycle.go Outdated Show resolved Hide resolved
lifecycle.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants