Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on Qt ADS repo and Gazebo #68

Merged
merged 7 commits into from
Sep 22, 2023

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Sep 20, 2023

Changes per commit message

@marip8 marip8 mentioned this pull request Sep 20, 2023
@marip8 marip8 force-pushed the update/ci branch 5 times, most recently from 58c6a30 to 84c1c2f Compare September 20, 2023 18:31
@Levi-Armstrong
Copy link
Contributor

Levi-Armstrong commented Sep 21, 2023

These are required for tesseract_qt_ros and should be maintained for the purpose of CI.

@marip8
Copy link
Contributor Author

marip8 commented Sep 21, 2023

tesseract_qt_ros currently has a COLCON_IGNORE, so my impression was that it was dev feature that's not complete or supported.

@Levi-Armstrong
Copy link
Contributor

Huh, from a ros perspective there is not much in here so it should not be hard to get it functioning.

@marip8
Copy link
Contributor Author

marip8 commented Sep 21, 2023

Would there be any reason that package couldn't live as a subdirectory of tesseract_qt instead? I don't exactly know what it does but it seems like a plugin for the studio; it seems like it might be more related to the studio stuff than the ROS stuff in this repo. Seems like you could optionally build it and use CMake to find the necessary ROS components to build it

@Levi-Armstrong
Copy link
Contributor

Would there be any reason that package couldn't live as a subdirectory of tesseract_qt instead? I don't exactly know what it does but it seems like a plugin for the studio; it seems like it might be more related to the studio stuff than the ROS stuff in this repo. Seems like you could optionally build it and use CMake to find the necessary ROS components to build it

It has ros plugin along with a studio node which is ros compatible. I do not want any of the tesseract ros agnostic repositories to have connection to ros components even if they are optional. This is in its own package so if you do not want the dependencies it can be ignored.

@marip8
Copy link
Contributor Author

marip8 commented Sep 21, 2023

That's fine. I think let's ignore it for now until we have time to make sure its fully supported. I would like to get Docker images generated for downstream projects for 0.18 and 0.19

@marip8 marip8 merged commit be4f117 into tesseract-robotics:master Sep 22, 2023
5 of 6 checks passed
@marip8 marip8 deleted the update/ci branch September 22, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants