Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Solve warning depreciated property managed policy ARNs (#79) #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borgeslima
Copy link

@borgeslima borgeslima commented Oct 24, 2024

feat: Solve warning depreciated property managed policy ARNs(#79)

Description

Solved warning depreciated property managed_policy_arns with aws_iam_role_policy_attachments_exclusive

Motivation and Context

The property is managed_policy_arns deprecated, generating a warning in the console

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…rm-aws-modules#79)

Solved warning depreciated property managed_policy_arns with aws_iam_role_policy_attachments_exclusive
@bryantbiggs
Copy link
Member

this would be a breaking change so we'll need to wait for the next breaking change

@borgeslima
Copy link
Author

@bryantbiggs it's working, the change is very simple, do you think the PR can generate problems?

Some Scan Tools in Do Not Pass Because of Warning do terraform. :/

@bryantbiggs
Copy link
Member

its a breaking change so it has the potential to disrupt users in a negative manner. I don't know what tools you are using but this is just a warning - its still perfectly valid configuration at this time

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants