remove BufferLeasePool#offer(BufferLease bufferLease); (#141)

closes #134
teragrep · Apr 17, 2024 · d0df8e5 · d0df8e5
1 parent 8d56264
commit d0df8e5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/src/main/java/com/teragrep/rlp_03/channel/buffer/BufferLeasePool.java b/src/main/java/com/teragrep/rlp_03/channel/buffer/BufferLeasePool.java
@@ -148,11 +148,6 @@ public List<BufferLease> take(long size) {
 
     }
 
-    // FIXME remove this, use BufferLease.removeRef() instead directly.
-    public void offer(BufferLease bufferLease) {
-        bufferLease.removeRef();
-    }
-
     /**
      * return {@link BufferContainer} into the pool.
      * 

diff --git a/src/main/java/com/teragrep/rlp_03/channel/context/RelpReadImpl.java b/src/main/java/com/teragrep/rlp_03/channel/context/RelpReadImpl.java
@@ -307,7 +307,7 @@ private void activateBuffers(List<BufferLease> bufferLeases) {
             }
             else {
                 // unused buffer, releasing back to pool
-                bufferLeasePool.offer(bufferLease);
+                bufferLease.removeRef();
             }
         }
     }

diff --git a/src/main/java/com/teragrep/rlp_03/frame/RelpFrameLeaseful.java b/src/main/java/com/teragrep/rlp_03/frame/RelpFrameLeaseful.java
@@ -111,7 +111,7 @@ public void close() {
             if (LOGGER.isDebugEnabled()) {
                 LOGGER.debug("releasing id <{}> with refs <{}>", bufferLease.id(), bufferLease.refs());
             }
-            bufferLeasePool.offer(bufferLease);
+            bufferLease.removeRef();
         }
         relpFrame.close();
     }

diff --git a/src/test/java/com/teragrep/rlp_03/channel/context/buffer/BufferLeasePoolTest.java b/src/test/java/com/teragrep/rlp_03/channel/context/buffer/BufferLeasePoolTest.java
@@ -97,7 +97,7 @@ public void testPool() {
 
         Assertions.assertEquals(1, lease.refs()); // initial ref must be still in
 
-        bufferLeasePool.offer(lease); // removes initial ref
+        lease.removeRef(); // removes initial ref
 
         Assertions.assertEquals(1, bufferLeasePool.estimatedSize()); // the one offered must be there