#0: Added option to filter perf results to within start/stop signposts #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksKnezevic
requested review from
boris-drazic,
eyonland,
arakhmati,
cfjchu,
xanderchin and
mo-tenstorrent
as code owners
arakhmati
approved these changes
Apr 30, 2024
AleksKnezevic
force-pushed
the
aknezevic/perf_test
branch
from
9e941fa
to
1b000fb
Compare
mo-tenstorrent
approved these changes
May 2, 2024
AleksKnezevic
force-pushed
the
aknezevic/perf_test
branch
from
2f7ab35
to
c533736
Compare
tt-rkim
approved these changes
May 3, 2024
TT-billteng
reviewed
May 3, 2024
TT-billteng
requested changes
May 3, 2024
TT-billteng
approved these changes
May 3, 2024
What do you want me to change about it? I wanted a quick way to disable these MMs for certain pipelines to retain CI coverage while the underlying issue is resolved. I can add more infra to do it via pytest but I'd have to pipe it through all the tests, so it would be a lot of changes for throwaway code. |
AleksKnezevic
force-pushed
the
aknezevic/perf_test
branch
from
07276d7
to
169a213
Compare
(cherry picked from commit a4ed4a1)
… hang observed on BM machine where perf tests are run.
AleksKnezevic
force-pushed
the
aknezevic/perf_test
branch
from
169a213
to
65c745e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.