Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in DRAM sharded MM #15569

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Fix race condition in DRAM sharded MM #15569

merged 3 commits into from
Nov 29, 2024

Conversation

yugaoTT
Copy link
Contributor

@yugaoTT yugaoTT commented Nov 29, 2024 •
edited
Loading

Ticket

Link to Github Issue

Problem description

this addition check prevents the race condition when issue read requests using tag id.

Checklist

@yugaoTT yugaoTT self-assigned this Nov 29, 2024
aliuTT
aliuTT approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@aliuTT aliuTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the relevant CI passes, but otherwise looks safe.

@yugaoTT yugaoTT marked this pull request as ready for review November 29, 2024 15:38
@yugaoTT yugaoTT merged commit a2b1b0b into main Nov 29, 2024
9 checks passed
@yugaoTT yugaoTT deleted the yugao/mm branch November 29, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliuTT aliuTT aliuTT approved these changes

@davorchap davorchap davorchap approved these changes

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

Assignees

@yugaoTT yugaoTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yugaoTT @davorchap @aliuTT