Disable upblock 3 and 4 unet unit tests #15568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 236622e changed parallelisation strategy for convs and adjusted unet model. Unet unit tests upblock 3 and 4 are failing with out of memory. Conv2d is now running at a larger grid and is better using available memory. UT is failing as it's not running the upblock in the exact same way as model tensors are not sharded not tialized and in different data format. This change will disable two unit tests that run out of memory, until we can rework the UT to be more like the model.
pavlejosipovic
requested review from
esmalTT,
uaydonat and
mywoodstock
as code owners
esmalTT
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 236622e
changed parallelisation strategy for convs and adjusted unet model.
Unet unit tests upblock 3 and 4 are failing with out of memory. Conv2d is now running at a larger grid and is better using available memory.
UT is failing as it's not running the upblock in the exact same way as model tensors are not sharded not tialized and in different data format. This change will disable two unit tests that run out of memory, until we can rework the UT to be more like the model.
Checklist