Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13875: fix tilize and attn matmul on BH #15459

Merged
merged 2 commits into from
Nov 27, 2024
Merged

#13875: fix tilize and attn matmul on BH #15459

merged 2 commits into from
Nov 27, 2024

Conversation

bbradelTT
Copy link
Contributor

@bbradelTT bbradelTT commented Nov 26, 2024

Ticket

Link to Github Issue #13875

Problem description

  • there were issues with attn matmul ops on BH

What's changed

  • updated llk commit
  • reverted z dim in tilize uninit
  • moved untilize init earlier

Checklist

Based on main...nvelickovic/fix_attn_matmul

@bbradelTT bbradelTT force-pushed the bbradel-13875_attn branch 2 times, most recently from 6ca52af to 50320cc Compare November 27, 2024 17:58
@bbradelTT bbradelTT merged commit 62e8824 into main Nov 27, 2024
9 checks passed
@bbradelTT bbradelTT deleted the bbradel-13875_attn branch November 27, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants