Populate the version based on Git Describe #15400
Open
+100
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afuller-TT
requested review from
tt-rkim,
vtangTT and
blozano-tt
as code owners
afuller-TT
commented
Nov 23, 2024
Comment on lines
+8
to
+12
| # These will be filled in by `git archive`. | ||
| # Building the source outside of git from something that was not exported via `git archive` | ||
| # is left as an exercise to whoever is wanting to do that. | ||
| set(fallbackVersion "$Format:%(describe)$") | ||
| set(fallbackHash "$Format:%h$") |
There was a problem hiding this comment.
Here's what this file looks like after it get tarball'd:
For Gitless builds, the version is the git describe of the commit that generated the archive.
afuller-TT
force-pushed
the
afuller/versioning
branch
from
2df0a43
to
96e9eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
None
Problem description
Prep work for packaging. We need to know our EXACT version. That means an up-to-date version string on every commit.
What's changed
Added a helper function that parses
git describeIntegrated
export-substto obtain version information after generating a tarball of the repoChecklist