Add tests for untilize, transpose, and tilize on non-4B aligned row-dim Row Major tensors + enable support for these tensors on untilize #15347

sjameelTT · 2024-11-21T22:19:23Z

Ticket

Problem description

Several OPs could not support RM inputs that were did not have 4B aligned rows.
Transpose, slice, untilize and tilize

What's changed

Lift the limitations on transpose, slice, untilize and tilize to enable support for odd row-dim BFP16 tensors
Increase transpose coverage on traces to 98.4%
Increase slice coverage on traces to 94.5%

Checklist

Post commit CI passes https://github.com/tenstorrent/tt-metal/actions/runs/11979119941
Blackhole Post commit (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/11962518460/job/33353111930 same issue as main
Model regression CI testing passes (if applicable)
Device performance regression CI testing passes (if applicable)
New/Existing tests provide coverage for changes

ntarafdar · 2024-11-21T23:15:42Z

.../ttnn/operations/data_movement/untilize_with_unpadding/device/untilize_with_unpadding_op.cpp

@@ -17,7 +17,6 @@ void UntilizeWithUnpadding::validate(const std::vector<Tensor>& input_tensors) c
    TT_FATAL(input_tensor_a.get_layout() == Layout::TILE, "Can only untilize tile major data");

    TT_FATAL(input_tensor_a.volume() % tt::constants::TILE_HW == 0, "Error");
-    TT_FATAL(((this->output_tensor_end[-1] + 1) % 2 == 0), "Can only unpad to row major tensor of even width");


I'm so happy seeing this line go away.

#12705: enable odd inner-dim RM bfloat16 untilize and add some unit tests #14227: add tests for odd inner-dim RM bfloat16 transpose #13749: unaligned RM transpose fix - also add more failing pt 2.0 cases

sjameelTT requested review from ayerofieiev-tt, dmakoviichuk-tt, rfurko-tt, cfjchu, TT-BrianLiu, razorback3, dongjin-na, ntarafdar, jaykru-tt and yugi957 as code owners November 21, 2024 22:19

ntarafdar reviewed Nov 21, 2024

View reviewed changes

ntarafdar approved these changes Nov 21, 2024

View reviewed changes

sjameelTT force-pushed the sjameel/to_layout_fix branch 2 times, most recently from b36462c to 96a7da9 Compare November 22, 2024 16:51

#15099: add tests for forge transpose case

e612654

#12705: enable odd inner-dim RM bfloat16 untilize and add some unit tests #14227: add tests for odd inner-dim RM bfloat16 transpose #13749: unaligned RM transpose fix - also add more failing pt 2.0 cases

sjameelTT force-pushed the sjameel/to_layout_fix branch from 96a7da9 to 6e5ef31 Compare November 22, 2024 19:15

#0: add tests and remove asserts to enable greater RM slice support

56c4420

sjameelTT force-pushed the sjameel/to_layout_fix branch from 6e5ef31 to 56c4420 Compare November 22, 2024 19:45

ayerofieiev-tt approved these changes Nov 23, 2024

View reviewed changes

sjameelTT merged commit c795acc into main Nov 23, 2024
122 checks passed

sjameelTT deleted the sjameel/to_layout_fix branch November 23, 2024 00:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for untilize, transpose, and tilize on non-4B aligned row-dim Row Major tensors + enable support for these tensors on untilize #15347

Add tests for untilize, transpose, and tilize on non-4B aligned row-dim Row Major tensors + enable support for these tensors on untilize #15347

sjameelTT commented Nov 21, 2024 •

edited

Loading

ntarafdar Nov 21, 2024

Add tests for untilize, transpose, and tilize on non-4B aligned row-dim Row Major tensors + enable support for these tensors on untilize #15347

Add tests for untilize, transpose, and tilize on non-4B aligned row-dim Row Major tensors + enable support for these tensors on untilize #15347

Conversation

sjameelTT commented Nov 21, 2024 • edited Loading

Ticket

Problem description

What's changed

Checklist

ntarafdar Nov 21, 2024

Choose a reason for hiding this comment

sjameelTT commented Nov 21, 2024 •

edited

Loading