Fix simulator setup #15227
Fix simulator setup #15227
Conversation
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
52384c4
to
e35523c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
5 times, most recently
from
a952a66
to
fa8455c
Compare
vtangTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
davorchap and
cfjchu
as code owners
|
Please drop |
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
55ee212
to
6bd9ff6
Compare
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
ed18000
to
f072046
Compare
| @@ -10,7 +10,7 @@ arc: | |||
| [ ] | |||
|
|
|||
| pcie: | |||
| [ ] | |||
| [ 0-0 ] | |||
There was a problem hiding this comment.
does the WH simulated soc have pcie cores? If not then I think we should remove this
There was a problem hiding this comment.
Yep should've removed this too, ty.
Removed now.
tt_metal/impl/device/device.cpp
Outdated
| this->device_kernel_defines_.emplace("PCIE_NOC_Y", std::to_string(pcie_cores[0].y)); | ||
| this->device_kernel_defines_.emplace("PCIE_NOC1_X", std::to_string(tt::tt_metal::hal.noc_coordinate(NOC::NOC_1, grid_size.x, pcie_cores[0].x))); | ||
| this->device_kernel_defines_.emplace("PCIE_NOC1_Y", std::to_string(tt::tt_metal::hal.noc_coordinate(NOC::NOC_1, grid_size.x, pcie_cores[0].y))); | ||
| if (std::getenv("TT_METAL_SIMULATOR_EN")) { |
There was a problem hiding this comment.
Passing in PCIe core to device temporary until we enable virtual coordinates but for now maybe we should:
| if (std::getenv("TT_METAL_SIMULATOR_EN")) { | |
| CoreCoord pcie_core = pcie_cores.empty() ? grid_size : pcie_cores[0] | |
| then use this as PCIE_NOC_X and PCIE_NOC_Y and calculate PCIE_NOC1* |
There was a problem hiding this comment.
I've removed the if cond with the env var, but pcie_noc1* are still hardcoded to 14 or 11 like before if pcie_cores.empty()
Not sure if there's a better way of doing this?
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
633bd19
to
567ea4e
Compare
Ticket
Link to Github Issue
Problem description
Provide context for the problem.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist