Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmp/mwang/tunneler ci2 #15225

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Tmp/mwang/tunneler ci2 #15225

wants to merge 13 commits into from

Conversation

miawangTT
Copy link
Contributor

Problem description

Add tunneler tests to micro benchmark test so that they can be run on BM machines.

Checklist

  • New/Existing tests provide coverage for changes

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 20, 2024

Are these deterministically passing now?

If you would like to do extra testing, I recommend using the custom test dispatch workflow to run your test in a loop on our VM infrastructure

@miawangTT
Copy link
Contributor Author

miawangTT commented Nov 20, 2024

Thanks for offering. We move this test from post-commit to micro-benchmark pipeline to make it run on BM machines instead of VMs as it is to check performance.

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 20, 2024

You can still custom dispatch onto BMs as well using the labels

["in-service", "pipeline-perf", "arch-wormhole_b0"]

And this should target our N300 perf BM.

I would recommend such to sniff out stability / non-determinant failure issues.

By the way, how long should these tests take?

@miawangTT
Copy link
Contributor Author

Thanks for letting me know! The codes have been modified to get rid of the prior failure (which is related to how fast a node can be set up on the machine). And it has been tested with for loops on both local and CI machines. The tests only take a few minutes to run.

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 27, 2024

How was running it? Did it look ok / stable?

@miawangTT
Copy link
Contributor Author

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 27, 2024

Beautiful, 10x
I approved yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants