Mo/14961 remove op alignment check #15097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-tenstorrent
requested review from
tt-rkim,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
mo-tenstorrent
force-pushed
the
mo/14961_remove_op_alignment_check
branch
from
f4f4c1b
to
4187291
Compare
tt-rkim
approved these changes
Nov 18, 2024
|
THANK YOU EMPEROR MO |
|
FOR NO LFS |
|
This is blocked on getting green device perf on main before we can test device perf on this branch. As perf ongoing conversations, |
tt-aho
approved these changes
Nov 18, 2024
Profiler post processing does not require all FW stars for and op to come before the last two FW ends
mo-tenstorrent
force-pushed
the
mo/14961_remove_op_alignment_check
branch
from
4187291
to
99051da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14961
Problem description
With the introduction of ring buffers, the requirement that all FW starts should come before the last two FW ends does not hold anymore. This was checked in profiler and some tests were asserting on it
What's changed
Ops are aligned using their opID and above requirement is checked by the profiler
NOTE: Profiler post processing mock tests are removed as they were not relevant anymore and were taking lfs space.
Checklist