Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double deallocate in llama3 attention #14951

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix double deallocate in llama3 attention #14951

merged 1 commit into from
Nov 12, 2024

Conversation

yieldthought
Copy link
Contributor

@yieldthought yieldthought commented Nov 12, 2024 •
edited
Loading

Ticket

N/A

Problem description

Llama 3 attention was deallocating the same tensor twice.

What's changed

Only deallocate attn_output_cat once.

Checklist

@mtairum mtairum merged commit a39f998 into main Nov 12, 2024
55 of 68 checks passed
@mtairum mtairum deleted the yieldthought/fix-double-free branch November 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtairum mtairum mtairum approved these changes

@cglagovichTT cglagovichTT Awaiting requested review from cglagovichTT cglagovichTT is a code owner

@uaydonat uaydonat Awaiting requested review from uaydonat uaydonat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yieldthought @mtairum