Add reduce_scatter t3k perf to pipeline #14950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNijjar
approved these changes
Nov 13, 2024
Aswinmcw
requested review from
jvegaTT,
blozano-tt,
ttmchiou,
tt-rkim,
TT-billteng and
afuller-TT
as code owners
jvegaTT
approved these changes
Nov 13, 2024
blozano-tt
approved these changes
Nov 13, 2024
ttmchiou
reviewed
Nov 13, 2024
| @@ -22,7 +22,8 @@ jobs: | |||
| { name: "t3k LLM llama3 model perf tests", model: "llama3", model-type: "LLM", arch: wormhole_b0, cmd: run_t3000_llama3_tests, timeout: 60, owner_id: U03PUAKE719}, # Miguel Tairum | |||
| { name: "t3k LLM falcon40b model perf tests", model: "falcon40b", model-type: "LLM", arch: wormhole_b0, cmd: run_t3000_falcon40b_tests, timeout: 75, owner_id: U053W15B6JF}, # Djordje Ivanovic | |||
| { name: "t3k CNN resnet50 model perf tests", model: "resnet50", model-type: "CNN", arch: wormhole_b0, cmd: run_t3000_resnet50_tests, timeout: 75, owner_id: U013121KDH9}, # Austin Ho | |||
| { name: "t3k CCL all_gather perf tests", arch: wormhole_b0, cmd: run_t3000_ccl_all_gather_perf_tests, timeout: 75, tracy: true, owner_id: ULMEPM2MA}, # Sean Nijjar | |||
| { name: "t3k CCL all_gather perf tests", model: "all_gather", arch: wormhole_b0, cmd: run_t3000_ccl_all_gather_perf_tests, timeout: 75, tracy: true, owner_id: ULMEPM2MA}, # Sean Nijjar | |||
| { name: "t3k CCL reduce_scatter perf tests", model: "reduce_scatter", arch: wormhole_b0, cmd: run_t3000_ccl_reduce_scatter_perf_tests, timeout: 75, tracy: true, owner_id: ULMEPM2MA}, # Sean Nijjar | |||
There was a problem hiding this comment.
Since these are the same owners and both all_gather and reduce_scatter tests take < 3mins.
Would it be a good idea to combine these into the same job?
The overhead to setup the same job is ~50s, and the time to run each individual CCL job is ~1mins
Aswinmcw
force-pushed
the
Aswinmcw/t3k_reduce_scatter_ci
branch
2 times, most recently
from
e803b9c
to
39d58a9
Compare
Aswinmcw
force-pushed
the
Aswinmcw/t3k_reduce_scatter_ci
branch
from
39d58a9
to
96d2b13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14406
Adds reduce_scatter t3k perf to pipeline
https://github.com/tenstorrent/tt-metal/actions/runs/11795073011/job/32854208345
Checklist