#12151: Replace avg_pool2d with global_avg_pool2d
#14330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrysky3
force-pushed
the
jerrysky3/remove-interim-avg-pool2d
branch
from
1f2c2d9
to
a082788
Compare
jerrysky3
changed the title
avg_pool2d with global_avg_pool2d
jerrysky3
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
yan-zaretskiy,
mywoodstock,
shwetankTT,
sankarmanoj-tt,
pavlejosipovic,
cfjchu and
TT-BrianLiu
as code owners
sankarmanoj-tt
approved these changes
Oct 28, 2024
jerrysky3
force-pushed
the
jerrysky3/remove-interim-avg-pool2d
branch
from
a082788
to
e674160
Compare
ayerofieiev-tt
approved these changes
Oct 29, 2024
mywoodstock
approved these changes
Oct 29, 2024
|
Thanks for the review! Could someone help me merge the PR? It seems like I still have no permission to merge |
pavlejosipovic
approved these changes
Oct 31, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
spoojaryTT
pushed a commit
that referenced
this pull request
Nov 25, 2024
### Ticket #12151 ### Problem description In ttnn currently there are `global_avg_pool2d` and `avg_pool2d`. Both of them do global average pooling (compute a single average of each channel). It seems that `avg_pool2d` is not a public API (couldn't be found on https://docs.tenstorrent.com/ttnn/latest/ttnn/ttnn) and most places in tt-metal use `global_avg_pool2d` This change removes the avg_pool2d and replace all its remaining usages with `global_avg_pool2d`. This frees up the name `ttnn.avg_pool2d` for the implementation of the actual average pooling API with kernel size (#12151) ### What's changed - Remove the export of `ttnn.avg_pool2d` (which is actually global average pool2d) - Replace the remaining usages of `avg_pool2d` in tt-metal with `global_avg_pool2d` ### Checklist - [x] Post commit CI passes (https://github.com/tenstorrent/tt-metal/actions/runs/11546482848) - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [x] New/Existing tests provide coverage for changes Co-authored-by: Artem Yerofieiev <169092593+ayerofieiev-tt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12151
Problem description
In ttnn currently there are
global_avg_pool2dandavg_pool2d. Both of them do global average pooling (compute a single average of each channel). It seems thatavg_pool2dis not a public API (couldn't be found on https://docs.tenstorrent.com/ttnn/latest/ttnn/ttnn) and most places in tt-metal useglobal_avg_pool2dThis change removes the avg_pool2d and replace all its remaining usages with
global_avg_pool2d. This frees up the namettnn.avg_pool2dfor the implementation of the actual average pooling API with kernel size (#12151)What's changed
ttnn.avg_pool2d(which is actually global average pool2d)avg_pool2din tt-metal withglobal_avg_pool2dChecklist