#12652: switch all-gather to worker initiated edm termination mode #14078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoraTT
reviewed
Oct 22, 2024
| @@ -750,7 +738,7 @@ operation::ProgramWithCallbacks all_gather_multi_core_with_workers_helper( | |||
| auto &sender_edm_builder = is_buffer_in_clockwise_direction(b) ? clockwise_edm_builders.at(i) : counter_clockwise_edm_builders.at(i); | |||
| log_trace(tt::LogOp, "Adding sender EDM channel"); | |||
| EriscDatamoverBuilder::ChannelBufferInterface const& sender_channel_buffer_info = | |||
| sender_edm_builder.add_sender_channel(sender_worker_writer_semaphore_id, clockwise_link_buffer_num_messages_to_send.at(b), sender_worker_coords); | |||
| sender_edm_builder.add_sender_channel(sender_worker_writer_semaphore_id, 1, sender_worker_coords); | |||
There was a problem hiding this comment.
is changing num_eth_messages_to_forward to 1 going to affect perf? Or is it just a semantic change?
There was a problem hiding this comment.
I'll update the code for readability. This just means the channel will actually forward data - the specific value itself doesn't matter so the API should be cleaned up. Thanks for the question.
avoraTT
reviewed
Oct 22, 2024
| @@ -302,6 +302,7 @@ operation::ProgramWithCallbacks all_gather_multi_core_with_workers_helper( | |||
| worker_defines["INTERLEAVED_MEM_LAYOUT"] = "1"; | |||
| } | |||
|
|
|||
| constexpr ttnn::ccl::EriscDataMoverTerminationMode edm_termination_mode = ttnn::ccl::EriscDataMoverTerminationMode::WORKER_INITIATED; | |||
There was a problem hiding this comment.
Does all gather not use EriscDataMoverTerminationMode::MESSAGE_COUNT_REACHED mode at all now?
There was a problem hiding this comment.
Correct. Both to simplify host code and to enable migration to fabric we won't be able to use a message_count type of mode anymore.
avoraTT
approved these changes
Oct 22, 2024
|
Hit some regressions and this work is being paused so I'll mark it draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
This change isn't strictly required. However, making this change will simplify some follow-up changes.
What's changed
This is a purely tactical/refactoring change that will simplify some follow up all-gather changes. Namely:
Checklist